add SIGHUP signal handler to allow rotation of pcap dump files #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kaian Are there any things I can help to get this merged, like adding more comments or explaining my reasoning for the individual parts of the code? |
|
Hi @g-v-egidy Sorry for the lack of feedback. The PR looks ok but I would like to test it. Sadly I'm involved in some other projects with higher priority right now and I had no ti me for testing it. I will try to do it during this week. Thanks a lot for the contribution and patience! |
|
Looks good to me! Thanks a lot for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps when you want to run sngrep in the background for a long time and you then want to use for example logrotate to rotate the pcap files written out for example every hour.