Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record line info on empty lines #873

Merged
merged 1 commit into from
Apr 24, 2018
Merged

record line info on empty lines #873

merged 1 commit into from
Apr 24, 2018

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Apr 16, 2018 •
edited
Loading

Fix for GL#31

josephbisch
josephbisch approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@josephbisch josephbisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this works.

@ailin-nemui
Copy link
Contributor Author

we just need to check if this could have any odd unforeseen effects. I can't find them but maybe someone else has an idea where to look?

@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Apr 17, 2018
@ailin-nemui
Copy link
Contributor Author

@irssi/developers

@ailin-nemui ailin-nemui merged commit e19d6ee into irssi:master Apr 24, 2018
@ailin-nemui ailin-nemui deleted the empty_lines branch April 24, 2018 11:58
This was referenced May 3, 2018
Closed
Merged
@ailin-nemui
Copy link
Contributor Author

had to be reverted

This was referenced Aug 15, 2018
Closed
Merged
@ailin-nemui ailin-nemui added this to the 1.1.2 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbisch josephbisch josephbisch approved these changes

Assignees
No one assigned
Labels
auto-merge This PR is scheduled for merge if no further comments are opened
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ailin-nemui @josephbisch