Build fix, update and cleanup dependencies #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use https for repos. Gradle already have a macros for mavenCentral() and it's the same as repo.maven.apache.org/maven2. The repo1.maven.org/maven2/ is deprecated and in fact the same mavenCentral()
Java 8 already have built-in date types
Use Jackson ObjectMapper instead
robevansuk
reviewed
Apr 21, 2020
|
|
||
| private String toJson(Object object) { | ||
| try { | ||
| ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
Spring provides an object mapper by default so we can autowire one into the constructor and utilise it here.
| private String toJson(Object object) { | ||
| try { | ||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| String json = objectMapper.writeValueAsString(object); |
There was a problem hiding this comment.
Again, this can be autowired in from Spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven central recently switched to HTTPS so we need to make some changes to fix a build.
Also newer JDKs was released so here is some update of Spring Boot and core dependencies