Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies setting of physics material on prims #30

Merged
merged 6 commits into from
Mar 4, 2023
Merged

Conversation

Mayankm96
Copy link
Contributor

@Mayankm96 Mayankm96 commented Mar 4, 2023

Description

This PR fixes some inconsistencies in the API to apply physics materials over prims. Isaac Sim recommends using the PhysicsMaterial and GeometryPrim classes but these are not general enough to apply any physics material on any prim. The material binding API expects the prim to be physics-enabled to apply a material on it. Thus, the main contribution of the PR is to make this generic, s.t. if given a prim, one can search all prims under it and apply the physics material wherever possible. This simplifies the requirement of having geom_prim_rel_path as part of the RigidObjectCfg.

Other additions to this PR:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file

@Mayankm96 Mayankm96 merged commit 19a316d into main Mar 4, 2023
@Mayankm96 Mayankm96 deleted the fix/rigid-object branch March 4, 2023 17:44
@Mayankm96 Mayankm96 added the bug Something isn't working label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant