Simplifies setting of physics material on prims #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some inconsistencies in the API to apply physics materials over prims. Isaac Sim recommends using the
PhysicsMaterial
andGeometryPrim
classes but these are not general enough to apply any physics material on any prim. The material binding API expects the prim to be physics-enabled to apply a material on it. Thus, the main contribution of the PR is to make this generic, s.t. if given a prim, one can search all prims under it and apply the physics material wherever possible. This simplifies the requirement of havinggeom_prim_rel_path
as part of theRigidObjectCfg
.Other additions to this PR:
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commit
checks with./orbit.sh --format
config/extension.toml
file