fix h3_great_circle_distance accepting degrees instead of rads #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
reviewed
May 31, 2024
src/h3_misc.cpp
Outdated
| LatLng latLng0 = {.lat = lat0, .lng = lng0}; | ||
| LatLng latLng1 = {.lat = lat1, .lng = lng1}; | ||
| LatLng latLng0 = {.lat = radsToDegs(lat0), .lng = radsToDegs(lng0)}; | ||
| LatLng latLng1 = {.lat = radsToDegs(lat1), .lng = radsToDegs(lng1)}; |
There was a problem hiding this comment.
Isn't this backwards? The input is degrees, right?
There was a problem hiding this comment.
Oops, yes, this is backwards. I've now checked the results against another online calculator & confirmed I get results that look comparable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105