-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superceded by tar-stream? #43
Comments
npm uses |
@othiym23 Fair enough, but can we leave this issue open to record that we may want to go through that process? |
As far as I know, npm is able to install from any tarball, and any modern tar implementation should unpack npm tarballs. So what edge cases are there? According to the benchmarks, it's also 10 times faster. I'd say it's reason enough to switch, especially because unpacking could be the slowest part of the install. |
@rlidwka That's an underestimation of the weird edge cases node-tar handles. We don't use tar(1) even if it's available for the same reasons. |
Extended attributes, custom headers, ACLs – if you've ever heard @isaacs talk about the time he put into getting |
I would imagine node-tar's tests might be such a conformance suite? Then again, I have no concept of how much isaacs believes in unit-testing. |
It looks to me like tar-stream has more functionality, generatlity, and a better API. Should work be done on node-tar when another package covers all that ground better than this one does?
The text was updated successfully, but these errors were encountered: