Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid return statement in outermost code block #3

Merged
merged 1 commit into from
Jan 5, 2016
Merged

avoid return statement in outermost code block #3

merged 1 commit into from
Jan 5, 2016

Conversation

mvayngrib
Copy link
Contributor

it makes some bundlers freak out (e.g. the React Native packager)

moved pseudomap to pseudomap.js

@gre
Copy link

gre commented Jan 4, 2016

dup with #1 ;)

@gre
Copy link

gre commented Jan 4, 2016

but I like your version too. let's wait @isaacs to choose the one he prefers :)

@mvayngrib
Copy link
Contributor Author

@gre haha react native is everywhere eh? Didn't see your PR when I submitted mine. I imagine @isaacs is pretty busy, so we might be here for a while

@isaacs isaacs merged commit 8953976 into isaacs:master Jan 5, 2016
This was referenced Jan 5, 2016
Closed
Closed
@gre
Copy link

gre commented Jan 5, 2016

@isaacs 👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvayngrib @gre @isaacs