Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space in filename #26

Closed
wants to merge 2 commits into from
Closed

Conversation

guybrush
Copy link
Contributor

No description provided.

@guybrush
Copy link
Contributor Author

note: removed unnecessary split/join by '/'

@rvagg
Copy link
Collaborator

rvagg commented Nov 18, 2013

lgtm now that you've remove the split/join, I can't see any obvious negatives here (famous last words). I'll merge, tag and version bump if @isaacs doesn't have anything to add in the next day or so but he'll still need to publish it.

@isaacs
Copy link
Owner

isaacs commented Nov 18, 2013

Pushed to the registry.

@rvagg Can you set up a gpg keychain with git, and then do sign-git-tag = true in your .npmrc file? That'll make your npm version git commits signed, which is a nice bonus for security. You're now a npm owner of st, so publish at will.

@isaacs isaacs closed this Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants