Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send headers on passthrough #34

Closed
wants to merge 1 commit into from

Conversation

joeybaker
Copy link
Contributor

Prevents aggressive cache headers from being set when st won't serve the route.

Prevents aggressive cache headers from being set when st won't serve the
route.
@rvagg
Copy link
Collaborator

rvagg commented Feb 13, 2014

oh, good one, will merge when I get a moment to have a good look at this, unless @isaacs does first, thanks!

@joeybaker
Copy link
Contributor Author

Thanks. I drifted a bit from the code style with the ternary operator and am calling .isDirectory() twice, but it seemed clean~ish to me?

FWIW, this caused a really subtle bug for us that took forever to track down.

@isaacs
Copy link
Owner

isaacs commented Feb 16, 2014

Landed on 2de1baa. Thanks!

@isaacs isaacs closed this Feb 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants