Allowing gzip compression to be disabled by setting gzip: false #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows gzip compression to be skipped by setting a
gzipoption tofalseWhy I needed this
My app is based around Restify, which provides its own
gzipResponsemiddleware. This middleware gzips all responses blindly. Restify can also serve static content, but its static content serving is very primitive. I wanted to use st for static content, but still allowgzipResponseto gzip everything. Without this setting, static content would get gzipped twice.It is simpler to set up my static endpoints and hand them off to st, than have gzipResponse try and figure out when it should or should not compress.
I'm not sure if this fits your vision for st, but I figured I send a pull request in case it does.