Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have configuration where I call
st
multiple times, and following setup lead to errors:Problem is that with first call, internally reusable
none
object is modified:https://github.com/isaacs/st/blob/master/st.js#L136
https://github.com/isaacs/st/blob/master/st.js#L157
With second st intialization,
dispose
goes to all other caches, and that at some point crashes sever:It's caused by stats objects from stat cache being provided to
dispose
of previous setup fd cache.I didn't provide test for it, as I'm not that familiar with current test setup, if it's something straightforward please guide and I'll add them.