Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download a update if a previous download action failed #66

Closed
alarraz opened this issue Jan 23, 2019 · 2 comments
Closed

Download a update if a previous download action failed #66

alarraz opened this issue Jan 23, 2019 · 2 comments
Labels
area/webapp kind/bug
Milestone
v1.1.0

Comments

@alarraz
Copy link
Contributor

alarraz commented Jan 23, 2019

When a download has failed, the state of the domain or resource change to DownloadFailed, after that the web don't let download again @jvinolas
@jvinolas
Copy link
Contributor

The thing to discuss here is: why the donwload failed? I assume there may be many situations where a download may fail. Do we have to threaten all them identically?

One option is to let the user start download again and also delete it. If we set the status to Deleting from DownloadFailed, it will work at engine level?

@jvinolas jvinolas added this to the 1.1.0 milestone Jan 26, 2019
@jvinolas
Copy link
Contributor

I've checked and we have a mismatch in this state definition as I found it as FailedDownload to be correctly controlled by UI but a mix of FailedDownload and DownloadFailed within engine.

We should continue using FailedDownload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/webapp kind/bug
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@jvinolas @alarraz