-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full KML exports are broken #514
Comments
But see also #510 |
@jessesnyder unfortunately the fix to #510 does not seem to have resolved this problem. This morning's export appears to have errored off (see https://atlantides.org/downloads/pleiades/kml/). |
I suspect that a damaged published Location somewhere may be causing this problem, but we can't no for sure unless the export can be run manually and watched for tracebacks or other errors. |
Attempting to run this manually, I do get an immediate failure. I'm not sure this is the same error that's happening "in the wild", or if I'm missing some set up. It is surprising that anything impacting this would have changed in mid-June. Command:
Excerpt of output:
|
Looks like it could be this commit: I see that a reference to Off to appt... tbc. |
Right. This was an attempt to provide better description text in the KML to show up on the kite so we can direct people back to the relevant Pleiades place, via a link. Some questions:
|
@paregorios Can you elaborate on what you hoped |
Update is on staging, @paregorios. Remember to re-test individual KML exports to verify the compound naming still works in this case (I tested locally and it worked for me). |
@jessesnyder will do. Did you manually run the bulk export and, if so, where should I look for it on staging path-wise? |
I didn't but I can do that now... I'll report back w/ the path |
KML serializations of single place resources, reached via links like "https://example.org/places/12345/kml" are working fine on staging. |
/srv/python27-apps/pleiades4/var/514_test.kml |
Overall, this is now looking like what we've long expected. Here's an example pop-up in Google Earth: @jessesnyder Can we use a similar quick test to eliminate the "In Context: Pleiades KML" line when we're doing the full dump, but keep the current behavior on the individual place serializations? |
Interestingly, that's added by the kml_topic_document.pt template, so we can't use the same test. I'd need to figure out how to determine the difference in context in that template. I'll see if I can figure this out quickly. |
@paregorios Deployed and ran the new code on production and the dump completed without errors. (I did not send the output to a file, so nothing to see, but it should run correctly from the cron job later). |
Fixed on production. Closing as resolved. |
Since at least 10 June 2024, all of the full Pleiades KML exports are only 172 bytes in size (i.e., the export process is erroring off before completion).
Individual KML exports seem to be OK in general. This is likely being caused by a single damaged Pleiades location, which we'll need to find.
Reported by Gabriel Mckee.
The text was updated successfully, but these errors were encountered: