Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some TF ops and add XLA backend #40

Merged
merged 42 commits into from
Sep 11, 2022
Merged

Add some TF ops and add XLA backend #40

merged 42 commits into from
Sep 11, 2022

Conversation

Co1lin
Copy link
Collaborator

@Co1lin Co1lin commented Sep 9, 2022

No description provided.

@Co1lin Co1lin requested a review from ganler September 9, 2022 12:25
Copy link
Member

@ganler ganler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!! In addition to those minor issues, would you also help add a dtype_test for tensorflow? Like https://github.com/ise-uiuc/nnsmith/blob/main/tests/torch/test_trt_backend.py#L56

nnsmith/backends/xla.py Outdated Show resolved Hide resolved
nnsmith/backends/xla.py Outdated Show resolved Hide resolved
@ganler
Copy link
Member

ganler commented Sep 10, 2022

Would you mind if I prioritize merging #41 as it alignes with an alpha release? I can help you sync this PR with latest branch.

@Co1lin
Copy link
Collaborator Author

Co1lin commented Sep 10, 2022

Would you mind if I prioritize merging #41 as it alignes with an alpha release? I can help you sync this PR with latest branch.

Sure. You can merge that, and I will sync with the latest main branch.

@ganler
Copy link
Member

ganler commented Sep 11, 2022

The conv2d spec should be fixed. TF's padding mechanism is quite different from torch. See https://www.tensorflow.org/api_docs/python/tf/nn#notes_on_padding_2

@ganler
Copy link
Member

ganler commented Sep 11, 2022

There are still a few things to fix later:

  • reproducibility: the seed obtained from the fuzzing loop cannot reproduce the same model in nnsmith.model_gen.
    • Oh I figured out: We need to both leverage the (model, backend) topset to have the exact same operator candidates.
  • Even the graph mode of TensorFlow might not support enough Data Types -- we also need to do dtype testing for the model generator.

@ganler ganler mentioned this pull request Sep 11, 2022
21 tasks
@ganler ganler merged commit b0dabcc into main Sep 11, 2022
@ganler ganler deleted the tf-ops branch September 11, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants