Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append multiple EDF in to one #2

Closed
Robindfuller opened this issue Aug 7, 2018 · 9 comments
Closed

Append multiple EDF in to one #2

Robindfuller opened this issue Aug 7, 2018 · 9 comments
Assignees

Comments

@Robindfuller
Copy link

Do you have a method for appending data from one EDF to another to produce a single EDF?

@ishiikurisu
Copy link
Owner

Sorry for taking so long to answer! No, I haven't implemented this yet, but I might do soon. The problem I see here is that we may run into frequency issues since the recordings in those files might be in different sampling rates, so appending data is not as direct as it might seem. I will think a little bit on this and I will generate a function for that.

@Robindfuller
Copy link
Author

Thanks. In my particular use case, the edf files come from the same recorder. At some point during the recording the device has split the data in to multiple files for any number of reasons. So the sample rate will the the same. However there might be a time gap between the files, maybe even just a few seconds.

@ishiikurisu
Copy link
Owner

This week, I implemented a function called edf.Append(x, y Edf) (*Edf, error), which concatenates data records on two EDF files. It still is on primitive state, and known bugs include not updating EDF+ annotations yet, but it might suffice some of your procedures. If you could test this function for me more thoroughly, it would be amazing!

The command line program edfappend on the EDF tools from the Neurosciences laboratory from University of Brasilia already implements a CLI for this function:

go build github.com/lab-neuro-comp/EDF-tools/app/edfappend
./edfappend fileA.edf fileB.df result.edf

@Robindfuller
Copy link
Author

I can't wait to try this. Thank you!

@ishiikurisu
Copy link
Owner

@Robindfuller, have you already tested this? If so, please provide feedback!

@ishiikurisu ishiikurisu self-assigned this Jan 30, 2019
@Robindfuller
Copy link
Author

Robindfuller commented Jan 30, 2019 via email

@ishiikurisu
Copy link
Owner

I see... I will close this issue by now, ok? Any news, just comment here so we can reopen this issue if needed. Meanwhile, I hope you enjoy your new project :)

@Robindfuller
Copy link
Author

Finally got round to trying this:

go build github.com/lab-neuro-comp/EDF-tools/app/edfappend
./edfappend fileA.edf fileB.df result.edf

It worked as expected. Thanks.

@ishiikurisu
Copy link
Owner

@Robindfuller thanks! that's good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants