Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later #259

ishkawa · 2018-07-25T13:18:08Z

UnsafeMutablePointer.deallocate(capacity:) is deprecated in Swift 4.1.

'deallocate(capacity:)' is deprecated: Swift currently only supports freeing entire heap blocks, use deallocate() instead

Since we deallocates entire heap blocks originally, we can just replace deallocate(capacity:) with deallocate() as compiler suggests.

ishkawa · 2018-07-25T13:23:02Z

Oops, we still need to use deallocate(capacity:) in Swift 4.0.

ikesyo

👍

Use buffer.deallocate() instead of buffer.deallocate(capacity:)

78d9e4c

Only use deallocate() in Swift 4.1 or later

c2bb90d

ishkawa changed the title ~~Use buffer.deallocate() instead of buffer.deallocate(capacity:)~~ Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later Jul 25, 2018

ikesyo approved these changes Jul 25, 2018

View reviewed changes

ishkawa merged commit bba530d into master Jul 25, 2018

ishkawa deleted the deallocate-entire-heap-blocks branch July 25, 2018 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later #259

Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later #259

ishkawa commented Jul 25, 2018

ishkawa commented Jul 25, 2018

ikesyo left a comment

Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later #259

Use buffer.deallocate() instead of buffer.deallocate(capacity:) in Swift 4.1 or later #259

Conversation

ishkawa commented Jul 25, 2018

ishkawa commented Jul 25, 2018

ikesyo left a comment

Choose a reason for hiding this comment