Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Misleading Comments in Code #20

Closed
ishuar opened this issue Jan 21, 2023 · 1 comment · Fixed by #23
Closed

Remove Misleading Comments in Code #20

ishuar opened this issue Jan 21, 2023 · 1 comment · Fixed by #23
Assignees
@ishuar

Comments

@ishuar
Copy link
Owner

ishuar commented Jan 21, 2023

  • In external-dns-iam.tf

    • Top comments are not relevant. No policy exists for external DNS in the policies directory.
    • Incorrect Heading for IAM policy document resource.

  • in exxternal-dns-service-account.tf

    • Update the name of file from exxternal-dns-service-account.tf to external-dns-service-account.tf : Typo
    • Header comment is incorrect.
@ishuar ishuar self-assigned this Jan 21, 2023
@ishuar
Copy link
Owner Author

ishuar commented Jan 22, 2023

remove machine info from jump-host-key.pub key.

ishuar pushed a commit that referenced this issue Jan 22, 2023
Remove Misleading Comments in Code #20
27f165e
@ishuar ishuar mentioned this issue Jan 22, 2023
Merged
ishuar added a commit that referenced this issue Jan 22, 2023
@ishuar
Remove Misleading comments (#23)
f00c05f 
* Remove Misleading Comments in Code  #20

* auto formatting of files for spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishuar ishuar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Misleading comments ishuar/terraform-aws-eks
1 participant
@ishuar