Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all collections are hashable #43

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Conversation

berquist
Copy link
Member

Removing attrs dependence in #38 meant that hashes for ImmutableMultiDicts were no longer automatically computed. The implementation is the same as in #40.

@berquist berquist requested a review from gabbard March 14, 2019 21:33
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #43 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   90.07%   90.23%   +0.16%     
==========================================
  Files           7        7              
  Lines         665      676      +11     
==========================================
+ Hits          599      610      +11     
  Misses         66       66
Impacted Files Coverage Δ
immutablecollections/_immutablemultidict.py 91.76% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5619f...899d54a. Read the comment docs.

@berquist berquist merged commit b77eb23 into master Mar 14, 2019
@berquist berquist deleted the 41-hashable-collections branch March 14, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants