-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PY3: Cannot encrypt to a file #93
Comments
Okay… this wasn't fixed with the changes from #92; it got more broken for Python3. |
isislovecruft
added a commit
that referenced
this issue
Mar 13, 2015
These issues were introduced in f8ccdc5. Because we no longer convert everything to an io.BytesIO in _encrypt() with _make_binary_stream(), all io.StringIO()s which are passed through must take encoded strings and io.BytesIO()s must take bytes (and there is actually a difference with Python3). Additionally, there appears to be an issue where the `outstream` passed to _copy_data() is sometimes a _io.BufferedWriter and other times an encodings.utf_8.StreamWriter. I am not sure yet where this problem was introduced. For now, the workaround for dealing with the Python3 bytes/str io.BytesIO/io.StringIO problem also provides a workaround for this issue. * FIXES #88. * FIXES #89 for Python3. * FIXES #93.
@doktorstick Thanks for reporting this issue! I just re-ran your example with Python3.4 after merging the above commit 43164fa into |
isislovecruft
added a commit
that referenced
this issue
Mar 13, 2015
isislovecruft
added a commit
that referenced
this issue
Mar 13, 2015
* FIXES Issue #93 for both Python2 and Python3.
isislovecruft
added a commit
that referenced
this issue
Mar 13, 2015
This provides more accurate testing for issues like #93.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: