-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker GUI instructions #4671
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @errissa and @ssheorey)
docs/getting_started.rst.in, line 147 at r1 (raw file):
2. X server: :bash:`-v /tmp/.X11-unix:/tmp/.X11-unix -e DISPLAY`
It would be more intuitive if we provide an end-to-end example with all commands to run, showcasing how to draw a basic geometry inside docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yxlao)
docs/getting_started.rst.in, line 147 at r1 (raw file):
Previously, yxlao (Yixing Lao) wrote…
It would be more intuitive if we provide an end-to-end example with all commands to run, showcasing how to draw a basic geometry inside docker.
I concur. If I didn't already know how to run Open3D from Docker I'm no sure these instructions are enough to get it correct. Also, is it not necessary to run xhost +
on the host in order for apps within docker to be able to access host X server?
Include complete example commands
71ebf64
to
fd67b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @errissa and @yxlao)
docs/getting_started.rst.in, line 147 at r1 (raw file):
Previously, errissa (Rene) wrote…
I concur. If I didn't already know how to run Open3D from Docker I'm no sure these instructions are enough to get it correct. Also, is it not necessary to run
xhost +
on the host in order for apps within docker to be able to access host X server?
Done.
Added complete example that containerizes the Open3D viewer. Drawing geometry is covered in other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @errissa, @ssheorey, and @yxlao)
docs/getting_started.rst.in, line 174 at r2 (raw file):
# Copy and install Open3D viewer from docker context COPY open3d-app-*.deb /root/
Could we mention how to get the .deb
file.
docs/getting_started.rst.in, line 201 at r2 (raw file):
.. code-block:: bash
Could we include how to create the Dockerfile here?
wget https://xxx/xxx/open3d-xxxx.deb
echo -e "FROM ubuntu:latest \nCOPY xxx ....\n" >> Dockerfile
That is, it would be ideal if copy-and-paste all commands can successfully launch the visualizer in Docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @errissa and @yxlao)
docs/getting_started.rst.in, line 174 at r2 (raw file):
Previously, yxlao (Yixing Lao) wrote…
Could we mention how to get the
.deb
file.
Done.
docs/getting_started.rst.in, line 201 at r2 (raw file):
Previously, yxlao (Yixing Lao) wrote…
Could we include how to create the Dockerfile here?
wget https://xxx/xxx/open3d-xxxx.deb echo -e "FROM ubuntu:latest \nCOPY xxx ....\n" >> Dockerfile
That is, it would be ideal if copy-and-paste all commands can successfully launch the visualizer in Docker.
Done.
Rename *.rst.in -> *.in.rst to allow viewing properly on github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docker — Open3D master (d781144d5) documentation.pdf
This change is