Dhruv2295/code refactor #128
Conversation
| @@ -240,11 +239,7 @@ protected void onCreate(final Bundle savedInstanceState) { | |||
| new ViewTreeObserver.OnGlobalLayoutListener() { | |||
| @Override | |||
| public void onGlobalLayout() { | |||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN) { | |||
There was a problem hiding this comment.
What about old Android versions?
There was a problem hiding this comment.
App's minimum supported version is 21. This check was checking for 18.
There was a problem hiding this comment.
Yes, makes sense. Android 5.0 (API level 21) = Lollipop.
| updateVehicleState(); | ||
|
|
||
| runOnUiThread( | ||
| new Runnable() { |
There was a problem hiding this comment.
Why use lambda previously but not here?
There was a problem hiding this comment.
There's no global converter in android studio to convert all these anonymous functions to lambdas at once.
So it's more of an iterative process, where I keep replacing them as and when I find them.
There was a problem hiding this comment.
I've converted this and pushed another commit
| LOGGER.e("Error receiving USB data"); | ||
| } | ||
| private final UsbSerialInterface.UsbReadCallback callback = | ||
| data -> { |
There was a problem hiding this comment.
What happens on error, since try/catch is removed?
There was a problem hiding this comment.
It was an android studio recommendation that this catch block would never be called. I'll add it back. Better safer.
dhruv2295
force-pushed
the
dhruv2295/code_refactor
branch
from
06957e7
to
d0c1e9f
Compare
Migration of dependencies to androidX.
Basic code cleanup to remove redundant initialisers.