-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create XL_Lego_body #342
Create XL_Lego_body #342
Conversation
@Christos-Ps note that no files have been added to this PR. Please let us know once it's ready for review. |
Dear @thias15 Please create the folder using the name XL_lego_body as it describes beter what is inside (there is an XL version with no lego bricks on top) Please find attached the readme file together with the STL files |
Dear @thias15 It seems i closed this "Pull Request" as i had the wrong impression that this was needed for you to proceed, so i reopened it now. Following our last communication, An increased height (XL) short version with front bumper and sleak top (no lego compatible) Best Regards |
@Christos-Ps. Ok, usually PR includes all the changes you want to propose. But I can take care of it. |
Thanks @thias15 !! I tried to create a file directly in https://github.com/isl-org/OpenBot/tree/master/body/diy/cad Cheers! |
You would have to do this in a fork, and then create a PR based on a branch in your fork. |
But I can prepare a PR and then you can review if that's easier. |
@Christos-Ps there seems to be some problems with the stl files. Could you please also provide the step files. |
@Christos-Ps also made a new PR #348 that adds a compatible README file, pending the STEP files and fixed STL files (I can also generate them if you provide me the step files). You can check it out here. |
Hi @thias15 I am afraid that i have no step files, as i made all changes with MeshMixer & Tinkercad.
Please feel free to let me know of the outcome! Cheers |
Hi @Christos-Ps. I checked the .obj files. Unfortunately they have the same artefacts. It is generally best to use the step files for making modifications (ideally in Fusions 360 - free for one year or a similar software). Working on the stl-meshes directly often creates problems. Would you be willing to redesign this model in Fusion360 to avoid such artefacts? I know this is extra work, but would be greatly appreciated. If not, would it be ok for you if we reimplement your design? |
Hi @thias15 It's a bit of overload on my side, but it can be also a good chance to learn a new software! :) |
@Christos-Ps thanks for your willingness to learn something new and putting in the extra effort. Once you get familiar with Fusion360 I'm sure you will love it. It is very powerful. |
No description provided.