Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a missing case in s2tte's is_assigned check #201

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix a missing case in s2tte's is_assigned check #201

merged 2 commits into from
Oct 12, 2023

Conversation

zpzigi754
Copy link
Collaborator

This PR is a minor fix in s2tte's checking logic. With the fix, the remaining test in ACS's rtt_read_entry will be passed.

[before]

   TOTAL TESTS     : 59
   TOTAL PASSED    : 11
   TOTAL FAILED    : 41

[after]

   TOTAL TESTS     : 59
   TOTAL PASSED    : 12
   TOTAL FAILED    : 40

@zpzigi754
Fix a missing case in s2tte's is_assigned check
2ee47dc 
With this fix, the remaining test in ACS's rtt_read_entry will be
passed.

[before]
```
      Positive Observability

       Unexpected Memory descriptor or RIPAS state
      (Check failed at:/home/changho/zpzigi754/islet/third-party/cca-rmm-acs/test/command/cmd_rtt_read_entry/cmd_rtt_read_entry_host.c ,line:369)
Result => Failed (Error Code=15)
```

[after]
```
      Positive Observability
Result => Passed
```
@zpzigi754 zpzigi754 mentioned this pull request Oct 12, 2023
Closed
@zpzigi754 zpzigi754 merged commit 0b4b217 into islet-project:main Oct 12, 2023
7 checks passed
@zpzigi754 zpzigi754 deleted the fix-rtt-read-entry branch October 12, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitboom bitboom bitboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpzigi754 @bitboom