Pass the remaining tests in data_create_unknown #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will pass the remaining tests in ACS's data_create_unknown.
zpzigi754
requested review from
bitboom,
nook1208,
bokdeuk-jeong,
jinbpark and
hihi-wang
[before] ``` ... [!] Setting islet features: ['--features', 'max_level_trace'] [!] Building realm management monitor...: islet [!] Building tf-a-tests... [!] Building bootloaders(bl1.bin, fip.bin)... [-] Test failed! (There are no proper result logs) Error: Process completed with exit code 1. ``` [after] ``` ... [!] Setting islet features: ['--features', 'max_level_error'] [!] Building realm management monitor...: islet [!] Building tf-a-tests... [!] Building bootloaders(bl1.bin, fip.bin)... [!] Tests result: 6 passed, 0 failed. [!] Setting islet features: ['--features', 'max_level_error'] [!] Building realm management monitor...: islet [!] Building realm(rsi-test)... [!] Building tf-a-tests... [!] Building bootloaders(bl1.bin, fip.bin)... [!] Tests result: 6 passed, 0 failed. ```
zpzigi754
force-pushed
the
fix-data-create-unknown
branch
from
5c79ceb
to
85c4e5d
Compare
jinbpark
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing checks in data_create_unknown. All the remaining tests in ACS's data_create_unknown will be passed after this change. It also includes the commit resolving the ci storage issue.
[before]
[after]