Feature/improve urls #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we specify the location of the tests. This means pytest doesn't need to recurse into loads of other folders, and so the collection of tests is way faster. I did a quick check and it went from ~8 seconds to <1 second.
This was causing a test to fail
(accidentally included in last commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urls for posts are now /posts/id_of_post/postname instead of what they used to be, /posts/postname. This means that we can lookup a post purely by its id, and the postname in the url can be changed with no consequence.
The url for adding a post was changed to /add_post/postname.
Tests/templates/code was updated to conform to this.
I also slightly modified pytest.ini to make the tests run faster.
See also #7.