Fix for handling symlinks to http-backed files #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzyTew
force-pushed
the
symlink-to-http
branch
from
e6b7968 to
4d145c1
Compare
|
Thanks for your patience! I think I've got my CI configured "properly" now: There's one pipeline for PRs (with not-so-secret environment variables, like SauceLabs access key) and a separate pipeline for |
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinks to backed files previously failed to read.
EDIT:
This PR adds a
path.resolvefunction to resolve chains of relative pathnames.The force push removed some unneeded changes to testfiles so the diff is cleaner.