fix: a shot in the dark at fixing the "Mutex double-freed" error #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billiegoose
changed the title
P0lip
approved these changes
Mar 3, 2020
| // need to attempt to release the mutex | ||
| this._activate().then(() => { | ||
| if (this._operations.size === 0) { | ||
| if (this._operations.size === 0 && !this._deactivationTimeout) { |
There was a problem hiding this comment.
I hope that the identifier is always a non-zero integer 
I'd need to look at the spec, but if it's not a hard requirement... 😆
There was a problem hiding this comment.
I looked at the spec. 😆
There was a problem hiding this comment.
let handle be a user-agent-defined integer that is greater than zero
source: https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html
|
🎉 This PR is included in version 3.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, "Mutex double-freed" has occurred ~200 times in production over the last 30 days.
So far the only possibility I see is maybe there is a way that PromisifiedFS can
_deactivatetwice, since_deactivationTimeoutis written to in two places.That said,
_deactivateitself is written to handle concurrency: you could call it 100 times concurrently, and it should only ever callthis._mutex.release()once. So I don't see how this can fix anything.