Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.2] Lost priceRangeLabel with variants... #1146

Closed
blairwinans opened this issue Jun 18, 2014 · 2 comments
Closed

[2.1.2] Lost priceRangeLabel with variants... #1146

blairwinans opened this issue Jun 18, 2014 · 2 comments
Labels
Milestone

Comments

@blairwinans
Copy link
Member

I just set up a site and added a product with several variants of differing prices, and the priceRangeLabel text that normally would have said something to the effect of "From $XX.00" when the product initially loads is missing.

I tracked it down to the logic here, which I am not sure makes sense if you are trying to get the "From... " logic. It would seem the models would need to be sorted highest price to lowest for that to work.

I ended up running usort() on $this->arrModels before the foreach loop to sort them highest to lowest, and that seemed to do the trick, but not sure if your logic is assuming something else?

@Toflar Toflar added the bug label Jun 26, 2014
@Toflar Toflar added this to the 2.1.3 milestone Jun 26, 2014
@Toflar
Copy link
Member

Toflar commented Jun 26, 2014

Same issue here. Have not looked into the code yet though.

@aschempp
Copy link
Member

usort would actually work, but is probably way too expensive. I've added a simple array of prices to see if there is more than one :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants