[2.1.14] document number hook broken

[Zeromax]

since b8fba25 the return value from the $GLOBALS['ISO_HOOKS']['generateDocumentNumber'] is not used anymore.

I have to save the value by my own cause saving of the value is moved inside of the try catch.
Otherwise my modified document_number would never be saved.

[aschempp]

This does not make sense to me, as the try-catch should not change anything, and the hook is not even in those code lines. Can you further explain the problem?

[Zeromax]

Yes it changes it ;) cause you moved the try catch inside the if clause ->

core/system/modules/isotope/library/Isotope/Model/ProductCollection.php

Line 1334 in b8fba25

if ($this->arrData['document_number'] == '') {

And so the Database update itself.

[aschempp]

That's not true. Check out the diff without whitespaces: b8fba25?w=1

The if statement is here since every version 2.x of Isotope: 53028b0#diff-0f55d18c670385e4d53dba5ad92a381aR1378

[aschempp]

Hah! Now I realized the problem. You're right, sorry, my fault.

[Zeromax]

@aschempp No problem. It is a bit tricky and took some time for me to see it too ;)

[aschempp]

Fixed in 2d2bae8