Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate price attribute in product and variant #1542

Closed
aschempp opened this issue Sep 26, 2015 · 2 comments
Closed

Validate price attribute in product and variant #1542

aschempp opened this issue Sep 26, 2015 · 2 comments
Assignees
@qzminski
Labels
feature
Milestone
2.4.0

Comments

@aschempp
Copy link
Member

It's not supported to have a price in the product and the variant. We should add a validation as this is something a lot of people do wrong.
@aschempp aschempp added this to the 2.x.x milestone Oct 23, 2015
@aschempp aschempp modified the milestones: 2.4.0, 2.x.x Mar 14, 2016
@aschempp
Copy link
Member Author

I think that validation should be on the product type. Just something like a save_callback on variant_attributes.

qzminski added a commit to qzminski/isotope-core that referenced this issue Mar 14, 2016
@qzminski
Validate the price attribute in product type against duplication (iso…
6231b59 
…tope#1542)
@qzminski qzminski mentioned this issue Mar 14, 2016
Merged
@aschempp
Copy link
Member Author

aschempp commented Apr 1, 2016

Implemented in #1626

@aschempp aschempp closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qzminski qzminski

Labels
feature
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
2 participants
@qzminski @aschempp