Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3.x] Edit Multiple/doNotShow Logic looks wrong #1589

Closed
blairwinans opened this issue Dec 22, 2015 · 1 comment
Closed

[2.3.x] Edit Multiple/doNotShow Logic looks wrong #1589

blairwinans opened this issue Dec 22, 2015 · 1 comment
Labels
bug
Milestone
2.3.3

Comments

@blairwinans
Copy link
Member

I cannot get custom attributes to show up in the Edit Multiple palette.

I am looking at line 349 in the DCA Manager, and the logic makes no sense to me. Am I wrong that it will almost always evaluate to true as it is?

It seems like it should be grouped like so:

if ((!isset($arrField['attributes']) || $arrField['inputType'] == '') && $name != 'inherit')

Then all my custom attributes show up nicely, as well as the inherit option.
@aschempp aschempp added the bug label Jan 19, 2016
@aschempp aschempp added this to the 2.3.3 milestone Jan 19, 2016
aschempp added a commit that referenced this issue Jan 19, 2016
@aschempp
Custom attributes did not show in edit-multiple mode (#1589)
b26a285
@aschempp
Copy link
Member

Event my IDE says you're right ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.3.3
Development

No branches or pull requests
2 participants
@aschempp @blairwinans