Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4.0] empty option for variant attribute #1738

Closed
Toflar opened this issue Nov 3, 2016 · 3 comments
Closed

[2.4.0] empty option for variant attribute #1738

Toflar opened this issue Nov 3, 2016 · 3 comments
Labels
Milestone

Comments

@Toflar
Copy link
Member

Toflar commented Nov 3, 2016

Attribute setup:

  • Options Manager
  • Mandatory field

If you make one variant the standard variant (default variant), the empty option in the front end still gets shown. This makes no sense because as you have a default variant, a choice is already made for the customer and as it is a mandatory field, there's absolutely no need for an empty option.

@Toflar
Copy link
Member Author

Toflar commented Nov 3, 2016

Imho it's this commit that needs to be adjusted now that it is possible :)

@aschempp
Copy link
Member

aschempp commented Nov 7, 2016

Unfortunately that's not really true. As far as I remember, we need the empty option to be able to "reset" the selection". Got to really test that though.

@aschempp
Copy link
Member

Blank option is only added for select menu's now, it does really not make sense for radios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants