Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 compatibility #1786

Closed
fredbliss opened this issue Mar 7, 2017 · 2 comments
Closed

PHP 7 compatibility #1786

fredbliss opened this issue Mar 7, 2017 · 2 comments
Labels
Milestone

Comments

@fredbliss
Copy link

fredbliss commented Mar 7, 2017

Are there plans in the works to ensure that isotope (isotope_rules, in this case) is php 7 compatible?

As an example of where this becomes a problem, please refer to https://github.com/isotope/core/blob/master/system/modules/isotope_rules/library/Isotope/Model/Rule.php#L283

mysql_real_escape_string() is used, but is deprecated in php 7. Is it even necessary to use that since the final mysql statement goes through Database->prepare() function?

@aschempp aschempp added the bug label Mar 9, 2017
@aschempp aschempp added this to the 2.4.2 milestone Mar 9, 2017
@aschempp
Copy link
Member

aschempp commented Mar 9, 2017

It's supposed to be compatible, but that sure is a bug I need to fix.

@aschempp
Copy link
Member

I have remove the use of this method in 65f4ce1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants