Security Update #1640
Closed
Security Update #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we change this, it will affect existing installations, right? |
|
Deffo! So please feel free to change the push destination appropriatly or close PR. |
|
can the user choose which hash algorithm to use in the Datatrans backend? Then we should probably provide the same options in Contao (similar as we do for Postfinance). |
|
Added select field for choosing the algorithm and the option to convert from hex2bin. Defaulted to md5 and 0, which will leave existing installation behaviour as is. I checked this on my system but i'd be happy if you could double check. Also i only added a german translation for it. |
|
This should be tagged 2.4 then. |
|
Merged in 50a3f97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datatrans changed security settings so the sign needs to be sha256 with the Datatrans HMAC hex being converted to bin before using it to generate the sign itself.