Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added decodeEntities to eval-Array of the Checkout-Step-Selection. #2194

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

kollmeier
Copy link
Contributor

@kollmeier kollmeier commented Feb 17, 2021

Validation fails otherwise because of the backslashes in the option values. Closes #2193

@kollmeier kollmeier changed the title Added decodeEntities to eval-Array of the Checkout-Step-Selection. Added decodeEntities to eval-Array of the Checkout-Step-Selection. Closes #2193 Feb 18, 2021
@kollmeier kollmeier changed the title Added decodeEntities to eval-Array of the Checkout-Step-Selection. Closes #2193 Added decodeEntities to eval-Array of the Checkout-Step-Selection. Feb 18, 2021
@aschempp
Copy link
Member

Thanks for the PR! The option labels shouldn't be relevant for validation. Does the step name contain backslashes in your case? Did you create your own checkout steps?

@kollmeier
Copy link
Contributor Author

It is not the label, which causes the problems. The value (or name) of the options are generated and contain the FQDN of the checkout-step (containing backslashes).

Wether I create own checkout steps or not leads to the same result: The checkout step select field of the MultiColumnWizard (as mentioned in #2193) doesn't validate, because \Isotope\CheckoutStep\PaymentMethod gets compared to \Isotope\CheckoutStep\PaymentMethod (for example)

After applying this submitted change, it works.

@aschempp aschempp added the bug label Feb 19, 2021
@aschempp aschempp added this to the 2.7 milestone Feb 19, 2021
@aschempp aschempp merged commit c09ac79 into isotope:2.7 Mar 31, 2021
@aschempp
Copy link
Member

Thank you @kollmeier

@aschempp aschempp modified the milestones: 2.7, 2.7.1 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validierung schlägt fehl, wenn Bestellbedingungsformulare für Checkout angegeben werden
2 participants