Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mandatory file uploads in order conditions not working #2228

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented May 27, 2021

Currently mandatory file uploads in order conditions do not work. When the form is submitted, Isotope will stay at the checkout/review step, without showing any error. The problem is that when checkout/process processes the order conditions checkout step again, $_FILES will be empty at this point and thus the file upload widget will not validate and therefore the whole order condition step will not validate, even though it was valid during the POST request.

To fix this $_FILES will need to be repopulated for the cloned widget when the checkout is processed.

@aschempp aschempp added the bug label Jun 7, 2021
@aschempp aschempp added this to the 2.7 milestone Jun 7, 2021
@aschempp aschempp modified the milestones: 2.7, 2.7.3 Jul 6, 2021
@aschempp aschempp merged commit a4a6098 into isotope:2.7 Jul 6, 2021
@fritzmg fritzmg deleted the patch-8 branch July 6, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants