Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move label generating logic in a separate method in DC_ProductData #2341

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

ameotoko
Copy link
Contributor

Fixes #2340

@aschempp
Copy link
Member

Is this intending to replace the method in Contao 4.13 and already use it in Contao 4.9? Do we really need to fix our own method or shouldn't the original issue be fixed in the Contao core method (of 4.13)?

@ameotoko
Copy link
Contributor Author

There's nothing to fix in Contao, Isotope uses custom driver with some custom logic in listView(), regarding list labels rendering. To be also compatible with 4.13, that logic needs to be available as a separate method.

That's exactly and only thing this PR does – it moves the block of code into a separate method. Does not break anything in 4.9.

@ameotoko
Copy link
Contributor Author

Any thoughts @aschempp?

@aschempp aschempp added the bug label Jun 2, 2023
@aschempp aschempp added this to the 2.9.0 milestone Jun 2, 2023
@aschempp aschempp changed the base branch from 2.8 to 2.9 October 17, 2023 06:50
@aschempp
Copy link
Member

Thank you @ameotoko! Finally got around to finish this. Now that we have Contao 4.13 this also got much easier 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array to string conversion in the product picker
2 participants