Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puck view - bug? #449

Open
StephMonaco opened this issue Jul 27, 2018 · 1 comment
Open

Puck view - bug? #449

StephMonaco opened this issue Jul 27, 2018 · 1 comment
Assignees
Labels

Comments

@StephMonaco
Copy link
Collaborator

These pucks were created with the old ISPYB interface and therefore the puck_type is not set properly but I don't understand why on the interface it states Unipuck and actually displayed as unipuck with 16 holes and on the prepare experiment it states SPinepuck.
Can you have a look what field you are looking for in these 2 cases?
Thanks for your help
Stephanie

image
image

antolinos added a commit to antolinos/EXI that referenced this issue Aug 1, 2018
@antolinos
Copy link
Collaborator

By clicking on edit, EXI checks the location of samples and modify the type accordingly:

if (_.maxBy(samples,"location").location > 10) {

For the grid in prepare experiment it does the same and when max(sample location)> 10 then it sets container type to spinepuck:

Looking at the code I found the problem and fixed it

antolinos added a commit that referenced this issue Aug 1, 2018
@antolinos antolinos self-assigned this Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants