Tests #139
Merged
Tests #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stufisher
force-pushed
the
fix/test
branch
2 times, most recently
from
b959c40
to
9f6746f
Compare
mgaonach
reviewed
May 5, 2022
Closed
|
Rebased on master |
|
Switched to using https://hub.docker.com/repository/docker/ispyb/ispyb-pydb published from https://github.com/ispyb/ispyb-docker-pydb |
clemenbor
approved these changes
May 6, 2022
There was a problem hiding this comment.
I was able to run the tests.
I only added requests as a dependency on requirements-dev.txt since the fastapi test client was missing it.
Also I excluded the folder "venv" within the setup.cfg for flake8. This is basically just convenient for people like me using Pycharm and the default virtual environments created by Pycharm.
|
Thanks for your review and changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix tests by: