Use <pre> for comments in admin area

[ix5]

Also update admin.css so that lines get wrapped

Note that document.getElementById().textContent() already overlooks the <pre> tags, so there is no need to strip them when using send_edit().

This is a dirty fix, but adding the client-side contenteditable mechanism here is something I'm not prepared to do. If anyone wants to pick this up, feel free to do so!

[ix5]

Hmm, since it seems no one has stepped up so far and provided a proper solution, I guess this is a good-enough stopgap one.

See #570

[hamoid]

Hi! Does this save the <pre> with the comment? And if you edit it multiple times, adds it each time?

Wouldn't it be better to do <div id="isso-text-{{comment.id}}" class="pre"> and create a .pre css style? (I may be totally wrong)

[ix5]

Hi! Does this save the <pre> with the comment? And if you edit it multiple times, adds it each time?

We have a saying in German: "He who is able to read has the clear advantage".
See in OP:

Note that document.getElementById().textContent() already overlooks the <pre> tags, so there is no need to strip them when using send_edit().

So rest assured, I already tested that "case" and am running it locally - it's working just fine.

Wouldn't it be better to do <div id="isso-text-{{comment.id}}" class="pre"> and create a .pre css style?

Well you want the browser to explicitly render and treat internally the text field as a <pre> element so that with the contenteditable property, you can edit the contents directly while preserving the line breaks etc.
If you only style it with pre styles, your nice manualy formatting, including the line breaks, will get stripped out, because in HTML, any amount of whitespace is collapsed into one.

[hamoid]

And he who has time to read has even more advantage :-P

[ix5]

@jelmer thoughts?

[jelmer]

Why <pre> rather than proper rendering?

[ix5]

Why <pre> rather than proper rendering?

Because then you'd have to deal with switching back and forth between editing markdown source and rendered HTML inside the admin interface - or worse, implement some variation of contenteditable with something like CKEditor or QuillJS.

IMO the admin interface should be kept simple, and admins can be expected to edit markdown themselves.

[ix5]

@fluffy-critter since you're taking a look at issues anyway, what are your thoughts? This is way easier than implementing the render functionality of the client embed js in admin once again.

[fluffy-critter]

I don't have any particular thoughts about this aspect.

[jelmer]

Okay, let's land this for the moment in lieu of a proper fix

[ix5]

In conjuntion with 2391e8e, this PR has opened up another annoying bug when editing comments from inside the admin area, appending literal <pre> tags when editing.

The admin really shouldn't be using contenteditable but rather proper forms, else we're opening a whole can of worms.