Add puppeteer end-to-end integration test #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Use comment stanzas above Jest unit tests that explicitly need the `jsdom` `testEnvironment`. Add `jest-environment-jsdom` package to `package.json` because it is now explicitly needed.
Necessitated by updated `jest` and added `jest-environment-jsdom` packages.
This should speed up a few testing steps and save bandwidth
Since the demo is also reachable at `http://localhost:8080`, add the origin to allowed hosts to allow easier testing.
ix5
force-pushed
the
js-puppeteer
branch
3 times, most recently
from
244848e
to
15f22f6
Compare
This is a baseline integration with more to come. To be run with: ```sh $ npm install jest-puppeteer $ npm run test-integration ``` Needs an Isso dev server at `http://localhost:8080` (or accepts a valid env var `ISSO_ENDPOINT` instead)
ix5
force-pushed
the
js-puppeteer
branch
4 times, most recently
from
b26952f
to
b3244fb
Compare
ix5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds end-to-end tests on top of #801.
Terminology
The
puppeteerintegration intoJestis done via the jest-puppeteer plugin, as recommended in Jest: Using with puppeteer.Note: Installing
puppeteervia npm auto-downloads an instance of Chromium intonode_modules/puppeteer/.local-chromium, which is around 400MB large!There might a way to disable this which I haven't bothered to find yet. Also, you might be able to define the browser used, e.g.
/usr/bin/chromiuminstead of the auto-download. Even Firefox seems to be supported.Running
You need to have a working Isso instance running on
localhost:8080in order for the end-to-end integration tests usingpuppeteerto work.Install the needed packages:
(I might add those to
package.jsonat some point, but the caveat of the chromium 400MB automatic download applies)Then run:
npm run test-unitfor Jest unit testsnpm run test-integrationfor puppeteer browser automationHighly WIP at the moment, but could be useful to someone else working on the same issues. Please communicate and collaborate!
Depends on #800. I have temporarily changed the base to that branch to make it easier to review this change.