js: template: Do not strip newlines #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-discriminatory newline stripping would wrongfully
collate pre-formatted (code) blocks.
The newline stripping/trimming was introduced as a
workaround because at the time, templates were written in
ES6 template literals (`${foo}`) and left a lot of newlines
in rendered HTML output, which lead to failures to convert
text to DOM elements using the `htmlify` helper.
These templates ended up being replaced by ES5 plain string
concatenation, which no longer requires the workaround.
Fixes isso-comments#856
Ensures that isso-comments#856 does not occur again: > This means that comments containing fenced code blocks - > which are rendered server-side as > `<pre><code>some code here\nanother new line</code></pre>` - > have their `\n` newline characters ignored when the > client-side JS renders, and so the whole output gets > rendered on one line. This makes code blocks hard to read. > > I'd quite like to keep these newline characters when the > comment is rendered. I tried just commenting that > newline-stripping line of code, and everything seems to > work. Is there a reason for this line being there?
ix5
force-pushed
the
js-template-no-strip-newline
branch
from
3aec338
to
4abdc29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-discriminatory newline stripping would wrongfully collate pre-formatted (code) blocks.
The newline stripping/trimming was introduced as a workaround because at the time, templates were written in ES6 template literals (
${foo}) and left a lot of newlines in rendered HTML output, which lead to failures to convert text to DOM elements using thehtmlifyhelper.These templates ended up being replaced by ES5 plain string concatenation, which no longer requires the workaround.
Fixes #856