Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra fields to RPC endpoints #50

Merged
merged 3 commits into from
May 26, 2023
Merged

Add extra fields to RPC endpoints #50

merged 3 commits into from
May 26, 2023

Conversation

andersfugmann
Copy link
Contributor

@andersfugmann andersfugmann commented May 23, 2023 •
edited
Loading

Add service_name, method_name and package_name to RPC modules.

Closes #49

@andersfugmann andersfugmann requested a review from a team as a code owner May 23, 2023 21:00
@andersfugmann andersfugmann mentioned this pull request May 23, 2023
Closed
@andersfugmann
Copy link
Contributor Author

@AndreasDahl / @tmcgilchrist Could I get a review on the changes in this PR. The changes are relative small and strait forward. Apart from adding new fields to auto generated service structs, it slightly changes how the name field is constructed. I suggest reviewing all changes in one go (and not per commit).

cheng81
cheng81 approved these changes May 26, 2023
View reviewed changes
Copy link

@cheng81 cheng81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

AndreasDahl
AndreasDahl approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@AndreasDahl AndreasDahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the PR 👍

@andersfugmann
Copy link
Contributor Author

Thanks both. Really appreciated.

@andersfugmann andersfugmann merged commit dbc151a into master May 26, 2023
@andersfugmann andersfugmann deleted the andersfugmann/add_fields_to_rpc branch May 26, 2023 09:46
@tmcgilchrist
Copy link
Contributor

tmcgilchrist commented May 27, 2023 via email

@andersfugmann andersfugmann mentioned this pull request Jun 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasDahl AndreasDahl AndreasDahl approved these changes

@cheng81 cheng81 cheng81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andersfugmann @tmcgilchrist @cheng81 @AndreasDahl