feat: Fix excludeAfterRemap functionality. #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2019
|
@coreyfarrell see my comments here; do we just bite the bullet and move away from the |
…ion (istanbuljs#982)" This reverts commit 509c6aa.
Previously excludeAfterRemap caused filtering to happen before remapping to original source filenames. This caused the filtering to be completely ineffective. Fix the order, add a test to verify functionality.
coreyfarrell
force-pushed
the
exclude-after-remap
branch
from
ea4c1ef
to
220f77d
Compare
JaKXz
reviewed
Mar 8, 2019
| }) | ||
| .option('include', { | ||
| alias: 'n', | ||
| default: [], |
There was a problem hiding this comment.
@coreyfarrell sorry for the post-review - shouldn't this be ['**']?
There was a problem hiding this comment.
Nope. An empty list is functionally equal to ['**'] but [] actually bypasses the check so it's more efficient.
https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/index.js#L50-L54 is where the default is processed, [] is replaced with false which short-circuits the include check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this qualifies as a feature or a fix, filtering after remapping has never worked. Original implementation of filtering remapped sources at dd40dc5, addition of excludeAfterRemap option at cdfdff3. Unfortunately the filtering step was done before coverage was remapped using source-maps, so it didn't do anything.
This is a potentially breaking change - bundled / compiled code was never filtered based on the original source filename, after this it will be. As an auxiliary change
test-excludeoptions are also added to thenyc reportandnyc check-coverageas those commands should process exclude-after-remap.Fixes #956