Removed yargs default for reporters so the ones defined in are taken first

[rapzo]

As pointed in issue #184.

[bcoe]

wouldn't this approach make it so that it's impossible to override the reporter:

nyc --reporter=lcov-text

the goal is a solution that uses the reporter defined in package.json iff the default reporter has been set by yargs?

[rapzo]

Yeah, you're right...
Well, i thought the expected behaviour was to run through the list of reporters defined in package.json when no reporter was provided by yargs. Shouldn't it be?

[rapzo]

Went a bit up and removed the yargs' default for reporters since it is set here when none provided. Seems to work both ways.

[bcoe]

@rapzo I dug into this a bit more, there's a slightly better solution that allows us to continue having a default value:

  .option('reporter', {
    alias: 'r',
    describe: 'coverage reporter(s) to use',
    global: true
  })

there appears to be a bug with yargs, which is taking into account aliases when loading defaults from the nyc stanza in the package.json. A temporary fix is to edit bin/nyc.js so that the long option name is used for the option rather than the alias.

I'd happily land this patch, but we should also dig into this bug in yargs.

[rapzo]

Sorry for the delay. Here's the patch. A better solution indeed.

[bcoe]

@rapzo give this a shot, shipped with your fixes for package configuration:

npm i nyc@next

If everything is looking good I'll promote the change to latest soon.

[rapzo]

I will! Thanks man!