Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #855

Merged
merged 4 commits into from
Jun 6, 2018
Merged

Conversation

coreyfarrell
Copy link
Member

This is related to istanbuljs/istanbuljs#180 and was tested against that.

@coreyfarrell
Copy link
Member Author

This did not have an error when testing within the istanbuljs monorepo, I think the failure is due to testing against the latest @next npm modules instead of testing against the pull request.

@coreyfarrell
Copy link
Member Author

@bcoe I'm not sure what it takes to publish new next versions of istanbuljs monorepo, this PR is on hold for that (it needs those changes to pass tests). I believe it's the change from micromatch to minimatch which changes the number of modules loaded.

@bcoe
Copy link
Member

bcoe commented Jun 6, 2018

@coreyfarrell I've released new next versions of the istanbul mono repo.

@coreyfarrell
Copy link
Member Author

@bcoe I thought you were going to bump istanbul-lib-hook to 2.0 since it has the a breaking API change? I've still updated the PR so this should soon pass CI.

@bcoe
Copy link
Member

bcoe commented Jun 6, 2018

@coreyfarrell see istanbuljs/istanbuljs#181, I will release shortly.

@bcoe
Copy link
Member

bcoe commented Jun 6, 2018

@coreyfarrell I have released istanbul-lib-hook at 2.x.

Update all dependencies to latest except yargs-parser.  The current
version of yargs depends on yargs-parser@^9.0.2 so do the same to avoid
duplicating the dependency.  Implement fixes to work with istanbuljs
master.

Replace mkdirp with make-dir, remove unused micromatch.
* Address differences is `standard`.
* Set versions to exactly that which is used by istanbuljs.
* Increase LAZY_LOAD_COUNT by one.
* Fix should.be.a.function to work with updated chai.
* Remove exists-sync in favor of fs.existsSync.
This allows nyc to play more nicely with the istanbuljs lerna monorepo.
Any dependencies used by both nyc and parts of istanbuljs will be
hoisted.
@bcoe bcoe merged commit f09cf02 into istanbuljs:master Jun 6, 2018
@coreyfarrell coreyfarrell deleted the require-hook-collision branch July 12, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants