Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null entries in sourcesContent #175

Closed
wants to merge 7 commits into from
Closed

Null entries in sourcesContent #175

wants to merge 7 commits into from

Conversation

glromeo
Copy link
Contributor

@glromeo glromeo commented Jan 4, 2022

I ran into an issue that was caused by sourceMaps having null values in the array of sourcesContent causing:

sourceRaw = sourceRaw.trimEnd()

...to throw an error.

This PR aims at filtering these null values which is consistent with the behaviour of :

const matchingSource = this.covSources.find(covSource => covSource.path === source)
covSource = matchingSource ? matchingSource.source : this.covSources[0].source
path = matchingSource ? matchingSource.path : this.covSources[0].path

...of ignoring source contents that might be missing

NOTE: This PR is meant to be merged after #173

@bcoe
Copy link
Member

bcoe commented Jan 9, 2022

@glromeo it looks like these changes were included in the perf fix we just landed.

@bcoe bcoe closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants