fix: Admiral crash when ArgoRolloutsEnabled set to false #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aattuluri
approved these changes
Mar 9, 2022
|
@itsLucario changes lgtm, please fix unit tests and the DCO check, instructions for DCO are here |
Signed-off-by: nbn01 <nandan_bn@intuit.com>
itsLucario
force-pushed
the
fix-ArgoRolloutsEnabled-false-panic
branch
from
8a0488a
to
83968d9
Compare
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 73.98% 74.00% +0.02%
==========================================
Files 26 26
Lines 2506 2508 +2
==========================================
+ Hits 1854 1856 +2
Misses 520 520
Partials 132 132
Continue to review full report at Codecov.
|
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
…stem#195) * fix panic: argoRolloutsEnabled=false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update test case with `argoRolloutsEnabled=true` Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
Added check before using RolloutClient to avoid nil deference when ArgoRolloutsEnabled=false, as it will not get initialized when set to false.