concurrent map issue #225
Merged
concurrent map issue #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
vinay-g
approved these changes
Jun 6, 2022
nirvanagit
reviewed
Jun 7, 2022
| @@ -69,6 +71,8 @@ func (s *serviceCache) getKey(service *k8sV1.Service) string { | |||
| } | |||
|
|
|||
| func (s *serviceCache) Get(key string) *ServiceClusterEntry { | |||
| defer s.mutex.Unlock() | |||
There was a problem hiding this comment.
nitpick: should we reverse them? Have s.mutext.Lock() and then defer ?
ccfishk
reviewed
Jun 7, 2022
| @@ -69,6 +71,8 @@ func (s *serviceCache) getKey(service *k8sV1.Service) string { | |||
| } | |||
|
|
|||
| func (s *serviceCache) Get(key string) *ServiceClusterEntry { | |||
| defer s.mutex.Unlock() | |||
There was a problem hiding this comment.
Suggested change
| defer s.mutex.Unlock() | |
| s.mutex.Lock() | |
| defer s.mutex.Unlock() |
ccfishk
approved these changes
Jun 7, 2022
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
nirvanagit
approved these changes
Jun 7, 2022
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #224
Added mutex to synchronize access to
Getfunc.