Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the doc differences for the configuration options #57

Closed
cfryanr opened this issue Nov 8, 2019 · 1 comment
Closed

Resolve the doc differences for the configuration options #57

cfryanr opened this issue Nov 8, 2019 · 1 comment

Comments

@cfryanr
Copy link

cfryanr commented Nov 8, 2019

When we moved to auto-generated docs, it looks like some small bits of documentation may have been lost.

Compare https://github.com/istio-ecosystem/authservice/blob/master/docs/README.md with the table from https://github.com/istio-ecosystem/authservice/tree/6dfd1ebd5a61034238fe73d791cb7cbf5262d733/bookinfo-example and resolve the diferences by updating the proto files (the source of the auto-generated docs).
@cfryanr
Copy link
Author

cfryanr commented Feb 14, 2020 •
edited
Loading

This was fixed by 70bda28

@cfryanr cfryanr closed this as completed Feb 14, 2020
nacx pushed a commit to nacx/authservice that referenced this issue Mar 11, 2024
@sergicastro
Remove mention to nanoseconds in the duration field (istio-ecosystem#57)
e6de973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfryanr